9
kamikaze
● 1 ● 9 ● 24
341/ 445
Oleg Korsak https://google.com/+OlegKorsak
Last seen 4 years ago
Member for 11 years, 1 month, 8 days
Difficulty Normal
Best reviews / Newest reviews
Hinted-veky 8 1
nice. but while you are trying to reduce line count you are violation PEP-8 and readability :) More
First-tamacjp 1
great to see identical solution as mine More
max-count-bryukh 1 2
great, but isn't it an overhead to run 27 times over the same string? More
First-berlinka
much better. but remember to indent blocks with blank lines too. More
First-berlinka
"cnt=0" -> "cnt = 0". You should learn PEP-8 better More
First-berlinka
don't use spaces for argument=value when calling/defining functions More
First-berlinka
use blank spaces to separate blocks More
Second-berlinka
[...] -> (...) learn about generators More
First-jfedot
with try-except there is less conditions to check. https://checkio.org/mission/index-power/publications/kamikaze/python-3/first/ More
Indexcept-veky 1
you are trying to get less lines and getting more mess More
First-berlinka
1) you don't need a result variable at all. 2) >= 10 is equal to >9 just return any(i.isupper() for i in data) and any(i.islower() for i in data) and any(i.isdigit() for i in data) and len(data) > 9 Think about optimization. Because you iterate data for 3 times, this is not optimal way. More
First-cabr0040
hint: sum() function could help you a lot More
First-cabr0040
actyally nothing to recommend here ) good job More
First-cabr0040
no need to estimate abs() every time. Just call it once and store result into variable More
First-jodemax
this is veeeery huge. and you are replacing so many times across whole resulting ss string More
First-berlinka
don't pay with readability for lesser line count. there is no need in braces for "not" also "if not i.isalpha()" == "if i.isdigit()", less to write, less to execute More
First-makoto_yamagata -1
cool, but not as clear as possible More