57
Awesome Team
Vedran Čačić
https://web.math.hr/~veky
Last seen 1 day ago
Member for 11 years, 6 months, 7 days
Difficulty Advanced
We shall not cease from exploration, and the end of all our exploring will be to arrive where we started and know the place for the first time.
Nice and surprisingly readable. With all those actions, you're only missing some kind of Journal in your architecture. :-P
More
Now you have two _languages_ that clash. Using % formatting could actually help readability here. ;-)
More
20 is a magical constant. Much better would be to use `itertools.takewhile`.
And x is _really_ slow. In fact it is used by some people as a trivial benchmark. :-) (Most famous example is probably [this one](https://www.youtube.com/watch?v=MCs5OvhV9S4).;)
More
I am wondering, is there a better solution for the words matching inside a sentence.-ruikang.dai
Yes, there is: Don't use regexen. :-D
More
First-Undinushka
1
Don't you think your code could use some refactoring? :-)
Also, everytime you write
if condition: return True
else: return False
a little python dies. :-P
More
my solution (quite long though)-quynhkhanh
About half of that length stems from keeping to the Pascal foolishness of a single return at the end of the function. Look:
def checkio(words):
words = words.split()
for i in range(0, len(words) - 2):
if words[i].isalpha() and words[i+1].isalpha() and words[i+2].isal
More
Roman Numerals-surenz298
1
Aaargh. Semantically empty names (`newList`, seriously??), the code is _drowned_ in the sea of comments (those things are connected: if you chose more semantical names, you wouldn't need comments!), and most importantly, you're doing iteration wrong.
for index in range(0, len(sequence)): ~~~
More
... a class which has three methods, one of which is `__init__`, and another one is a staticmethod. :-P
Anyway, you can use OO as G-d* intended with a classmethod.
@classmethod
def from_geo(cls, geo_coords):
...
return cls(*map(...))
*] G-d refers to Guido, of course. :-)
More
The title is the reference to [this solution](https://py.checkio.org/mission/number-radix/publications/johngraham/python-3/newbie-trying-to-learn-python-style/).
More
Line 5: even index is not the same as even element.
[x for i, x in enumerate(array) if not i%2]
is what you probably meant.
More
Nice variable names. Unfortunately, not much else nice can be said about the above code.
More
> That was a hard nut to break
Well, I guess it depends on the [approach](https://www.youtube.com/watch?v=zknBWLBXWGs). :-D
def checkio(number):
rn, roman = 'M__ CDM XLC IVX'.split(), []
for digit, (one, five, ten) in zip(str(number).zfill(4), rn):
numerals = ['', o
More
You already know what Unicode is. :-)
But that duplication above is really bad. :-/
More
Those semicolons randomly sprinkled through your code don't seem very clear. :-]
More
